Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to DART_HOME #45

Merged
merged 4 commits into from Oct 11, 2021
Merged

Tweaks to DART_HOME #45

merged 4 commits into from Oct 11, 2021

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Oct 11, 2021 •
edited

Some small tweaks to DART_HOME to ensure:

  1. We use a backslash on windows
  2. We don't add a terminating slash (Github doesn't do that on their variables)

Behavoir seen in the test run:

Linux:

Run echo "Dart SDK installed in $DART_HOME"
Dart SDK installed in /opt/hostedtoolcache/dart-sdk

macOS:

Run echo "Dart SDK installed in $DART_HOME"
Dart SDK installed in /Users/runner/hostedtoolcache/dart-sdk

Windows:

Run echo "Dart SDK installed in $DART_HOME"
Dart SDK installed in C:\hostedtoolcache\windows\dart-sdk

@mit-mit mit-mit requested a review from athomas October 11, 2021 09:33
athomas
athomas approved these changes Oct 11, 2021
View reviewed changes
setup.sh Outdated
@@ -88,14 +88,16 @@ rm "${HOME}/dartsdk.zip"
if [[ $OS == windows ]]
then
PUBCACHE="${USERPROFILE}\\.pub-cache"
DARTHOME="${RUNNER_TOOL_CACHE}\\dart-sdk"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just call this DART_HOME (rather than DARTHOME)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mit-mit mit-mit merged commit 6a218f2 into main Oct 11, 2021
@mit-mit mit-mit deleted the mit-mit-patch-1 branch October 11, 2021 14:08
@mit-mit mit-mit mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athomas athomas athomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mit-mit @athomas