Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pub cache issue in Windows #39

Merged
merged 6 commits into from Jul 26, 2021
Merged

Fix pub cache issue in Windows #39

merged 6 commits into from Jul 26, 2021

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Jul 26, 2021 •
edited

Make sure that the PUB_CACHE is set with back-slashes on Windows

Fixes #32

@mit-mit mit-mit changed the title Git deps Fix pub cache issue in Windows Jul 26, 2021
@mit-mit mit-mit requested a review from athomas July 26, 2021 16:04
kevmoo
kevmoo approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!!!

@mit-mit
Copy link
Member Author

mit-mit commented Jul 26, 2021

I think this might fix that other pub issue you had with setup-dart recently?

@mit-mit mit-mit merged commit 989c094 into dart-lang:main Jul 26, 2021
@mit-mit mit-mit deleted the gitdeps branch July 26, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@athomas athomas Awaiting requested review from athomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get dependencies fails on Windows if dependency is a git ref
2 participants
@mit-mit @kevmoo