Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to setup raw builds for all channels #36

Merged
merged 2 commits into from Jul 19, 2021

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jul 8, 2021

This allows developers relying on SDK changes to land and test changes
in other packages using a raw dev build so we can validate changes,
publish them, and roll to dependent packages (such as flutter) faster.

Closes: #29

This allow developers reying on SDK changes to land and test changes
in other packages using a raw dev build so we can validate changes,
publish them, and roll to dependent packages (such as flutter) faster.

Closes: dart-lang#29
Copy link
Member

@sigmundch sigmundch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, in my attempt (#37) I used a "signed" boolean instead of the raw/release strings as a parameter. My rationale was to hide the name of the folders and make it more about the semantics (one is signed the other is unsigned and unpublished).

But honestly I was torn between both options. Maybe @athomas has a preference?

I also explored an option of using a dev_unpublished channel, but I think the flavor/signed option is better.

@annagrin
Copy link
Contributor Author

annagrin commented Jul 8, 2021

@sigmundch I am fine either way, I'll wait for @athomas to comment.

@sigmundch sigmundch requested a review from whesse July 13, 2021 18:15
@sigmundch
Copy link
Member

@whesse would you be able to take a look while @athomas is on vacation?

.github/workflows/dart.yml Show resolved Hide resolved
@annagrin annagrin closed this Jul 19, 2021
@annagrin annagrin reopened this Jul 19, 2021
@mit-mit
Copy link
Member

mit-mit commented Jul 19, 2021

Thanks for the update, LGTM for merging

@whesse
Copy link

whesse commented Jul 19, 2021

I just tested downloading the ARM64 MacOS raw build of the SDK, and running dart on a Mac M1 machine, and it worked. So it will be fine to use the unsigned raw bits, I believe, even on the one configuration which might require a signed one. (Actually, the raw build is signed too, just self-signed with a local certificate).

@annagrin
Copy link
Contributor Author

annagrin commented Jul 19, 2021

@whesse thank you for testing this! I made this change to make iteration over cross-repo features faster (for example, webdev can test against raw dev SDK bits in its CI which are available faster than the release bits), hopefully it can be helpful for others as well.

@annagrin annagrin merged commit fa07b23 into dart-lang:main Jul 19, 2021
@annagrin annagrin deleted the annagrin/add_unreleased_dev_channel branch July 19, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for dev_unpublished
4 participants