Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pub global on Windows + add test #20

Merged
merged 7 commits into from Feb 8, 2021
Merged

Fix pub global on Windows + add test #20

merged 7 commits into from Feb 8, 2021

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Feb 5, 2021 •
edited

  • Fix a pub global path issue resulting in globals not working correctly on Windows
  • Add testing of pub globals

Fixes #5

@mit-mit mit-mit changed the title Add testing of pub global Fix pub global on Windows + add test Feb 5, 2021
@mit-mit mit-mit marked this pull request as ready for review February 5, 2021 15:02
kevmoo
kevmoo approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo is well tested 😄

@mit-mit mit-mit merged commit e391a10 into main Feb 8, 2021
@mit-mit mit-mit deleted the mit-mit-patch-1 branch February 8, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@athomas athomas athomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing of pub
3 participants
@mit-mit @kevmoo @athomas