Supports more arguments in path.join API #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
force-pushed
the
path_join_supports_more_args
branch
5 times, most recently
from
f59e602
to
fd0a68f
Compare
|
Should add a changelog entry. I'm a bit 🤷 – @natebosch ? @devoncarew ? |
hellohuanlin
force-pushed
the
path_join_supports_more_args
branch
from
fd0a68f
to
6f64c02
Compare
hellohuanlin
force-pushed
the
path_join_supports_more_args
branch
from
6f64c02
to
17e7246
Compare
natebosch
approved these changes
Nov 11, 2022
natebosch
reviewed
Nov 11, 2022
|
I think i need an approval to run the workflows. |
natebosch
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on flutter tools, occasionally I need 9-12 parts, and it's a bit annoying to have to break them up.
Why 16 arguments? 16 should be good enough to cover most cases (based on my experience on tools repo in the past few weeks). I doubt there's a good reason for 8 either (not documented at least), so i just double it to 16.