Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Supports more arguments in path.join API #130

Merged

Conversation

hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Nov 11, 2022

When working on flutter tools, occasionally I need 9-12 parts, and it's a bit annoying to have to break them up.

Why 16 arguments? 16 should be good enough to cover most cases (based on my experience on tools repo in the past few weeks). I doubt there's a good reason for 8 either (not documented at least), so i just double it to 16.

@hellohuanlin hellohuanlin force-pushed the path_join_supports_more_args branch 5 times, most recently from f59e602 to fd0a68f Compare November 11, 2022 00:51
@kevmoo kevmoo requested a review from natebosch November 11, 2022 02:36
@kevmoo
Copy link
Contributor

kevmoo commented Nov 11, 2022

Should add a changelog entry. I'm a bit 🤷 – @natebosch ? @devoncarew ?

@hellohuanlin hellohuanlin force-pushed the path_join_supports_more_args branch from fd0a68f to 6f64c02 Compare November 11, 2022 18:52
@hellohuanlin hellohuanlin force-pushed the path_join_supports_more_args branch from 6f64c02 to 17e7246 Compare November 11, 2022 19:31
@hellohuanlin hellohuanlin marked this pull request as ready for review November 11, 2022 19:33
@hellohuanlin
Copy link
Contributor Author

I think i need an approval to run the workflows.

@natebosch natebosch merged commit 12ce876 into dart-archive:master Nov 14, 2022
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 16, 2024
Add additional optional positional arguments to some methods.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants