Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider unawaited_futures for inclusion #25

Open
1 of 3 tasks
mit-mit opened this issue May 12, 2021 · 6 comments
Open
1 of 3 tasks

Consider unawaited_futures for inclusion #25

mit-mit opened this issue May 12, 2021 · 6 comments
Assignees

Comments

@mit-mit
Copy link
Member

mit-mit commented May 12, 2021

We had initially selected unawaited_futures for inclusion in core lints, however ran into some issues that need resolving first, including:

@jacob314
Copy link
Member

jacob314 commented Jun 2, 2021

+1 on adding a method side opt out for unawaited_futures. We see a very large # of calls to unawaited in g3 (about 10% of all calls to awaited). Likely a small # of method side opt outs can reduce this # significantly.

@pq
Copy link
Member

pq commented Jun 2, 2021

@goderbauer: do any Flutter APIs spring to mind that you'd want to tag as unwaitable? it'd be handy to have some concrete examples to drive the discussion.

@goderbauer
Copy link
Contributor

The Future-returning APIs on AnimationController and Navigator are the most common examples, things like AnimationController.forward() / AnimationController.reverse() and Navigator.push() as well as its similarly named friends.

@pq
Copy link
Member

pq commented Jun 2, 2021

Corresponding issue to discussion an annotation in pkg:meta here: dart-lang/sdk#46218.

@natebosch
Copy link
Member

@mit-mit mit-mit added this to Triage backlog in Lints triage Jan 10, 2022
@mit-mit
Copy link
Member Author

mit-mit commented Jan 11, 2022

@pq to create a proposal for how this would work

@mit-mit mit-mit moved this from Triage backlog to Icebox in Lints triage Jan 11, 2022
@devoncarew devoncarew changed the title Consider 'unawaited_futures' for inclusion Consider unawaited_futures for inclusion Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: More investigation needed
Lints triage
Needs work/investigation
Development

No branches or pull requests

5 participants