Add a comment about NaN in min/max extensions #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Apr 7, 2022
lrhn
reviewed
Apr 7, 2022
lib/src/iterable_extensions.dart
Outdated
| @@ -592,6 +592,8 @@ extension IterableNullableExtension<T extends Object> on Iterable<T?> { | |||
| /// since doubles require special handling of [double.nan]. | |||
| extension IterableNumberExtension on Iterable<num> { | |||
| /// A minimal element of the iterable, or `null` it the iterable is empty. | |||
| /// | |||
| /// If an element is NaN, it is considered to be a minimal element. | |||
There was a problem hiding this comment.
Hmm, pretty over-engineered code, now that I look at it again.
num? get minOrNull {
var empty = true;
var min = double.infinity;
for (var value in this) {
empty = false;
if (value.isNaN) return value;
if (value < min) min = value;
}
if (empty) return null;
return min;
}seems much more optimizable.
(Maybe I should make a benchmark 😁)
lrhn
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that NaN will be both min and max, which might be confusing to the user if not documented.
I do think returning NaNs is better approach than the other 2 alternatives I can think of:
falsefrom comparisons to NaN, which will lead to inconsistent returns depending on NaN's placement (e.g. first or not first) in the iterable.