Introduce a new associateBy() function #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Oct 25, 2021
kevmoo
reviewed
Oct 25, 2021
|
Changelog entry added. |
lrhn
reviewed
Oct 25, 2021
lib/src/functions.dart
Outdated
| } | ||
|
|
||
| return map; | ||
| } |
There was a problem hiding this comment.
Can be done using a map literal:
=> {for (var element in values) key(element): element};and I think it should be.
|
@Kernald - are you still interested in this feature? |
|
@natebosch Sorry this kind of slipped out of my attention - I still think it would be nice to have. Should I go ahead and update the test as requested, and rename this as |
|
Yeah if you apply the feedback given so far we can do another round of review and keep this moving forward. Thanks for the contribution! If you need any help resolving merge conflicts or have any questions I can help. |
|
Rebased, and addressed the feedback:
|
lrhn
reviewed
May 30, 2022
lrhn
reviewed
May 31, 2022
Similar to groupBy(), except that it only keeps the latest value corresponding to a given key. Prior art: [Kotlin](https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.sequences/associate-by.html)
lrhn
approved these changes
Jun 1, 2022
|
Is there anything left preventing a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to groupBy(), except that it only keeps the latest value corresponding to a given key.
Prior art: Kotlin