Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures with "Flag additional code as unreachable due to types Null and Never." #1398

Closed
stereotype441 opened this issue Aug 19, 2022 · 0 comments
Closed

Failures with "Flag additional code as unreachable due to types Null and Never." #1398

stereotype441 opened this issue Aug 19, 2022 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@stereotype441
Copy link
Member

There are new failures with Flag additional code as unreachable due to types Null and Never., which I'll be landing shortly.

See dart-lang/sdk#49635 for a detailed explanation of what is being changed.

The tests

co19/LanguageFeatures/nnbd/expression_typing_A02_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/nnbd/expression_typing_A03_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/nnbd/static_errors_A17_t03 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/nnbd/static_errors_A17_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/expression_typing_A02_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/expression_typing_A03_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/static_errors_A17_t03 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/static_errors_A17_t04 MissingCompileTimeError (expected Pass)

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-strong-linux-x64-chrome
dart2js-hostasserts-weak-linux-x64-chrome
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-x64
@sgrekhov sgrekhov self-assigned this Aug 22, 2022
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Aug 22, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 22, 2022
@sgrekhov
Fixes dart-lang#1398. Fix tests that use unreachable code after Never
cd7f50a
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 1, 2022
@sgrekhov
dart-lang#1398. Change testing members of Never
a6d8ea6
@eernstg eernstg closed this as completed in efd1d26 Sep 1, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 12, 2022
@sgrekhov @athomas
[co19] Roll co19 to 3c9ba02a1e4bfc416ff3cd05df512d63deacd885
272a108 
2022-09-02 sgrekhov22@gmail.com dart-lang/co19#1399. on clause tests added (dart-lang/co19#1416)
2022-09-02 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Type annotations and record expressions tests updated (dart-lang/co19#1415)
2022-09-01 sgrekhov22@gmail.com Fixes dart-lang/co19#1398. Fix tests that use unreachable code after `Never` (dart-lang/co19#1402)
2022-08-31 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Typos in subtyping tests description fixed (dart-lang/co19#1414)
2022-08-31 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Subtyping tests for records added (dart-lang/co19#1412)
2022-08-31 asashour@yahoo.com Fix typo (dart-lang/co19#1413)
2022-08-30 sgrekhov22@gmail.com dart-lang/co19#1405. BytesBuilder tests moved from dart:io to dart:typed_data (dart-lang/co19#1410)
2022-08-30 sgrekhov22@gmail.com dart-lang/co19#1399. Tests for record types. Part 1 (dart-lang/co19#1395)
2022-08-24 sgrekhov22@gmail.com dart-lang/co19#1405. Don't use deprecated API in co19 tests. Update generated files (dart-lang/co19#1407)
2022-08-24 sgrekhov22@gmail.com dart-lang/co19#1405. Don't use deprecated API in co19 tests (dart-lang/co19#1406)
2022-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1361. Private fields promotion tests added (dart-lang/co19#1391)
2022-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1394. Add missing compile-error (dart-lang/co19#1396)
2022-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1403. Added test that `super` cannot be used as an expression (dart-lang/co19#1404)
2022-08-15 sgrekhov22@gmail.com dart-lang/co19#1388. FFI tests fixed for 32-bit systems (dart-lang/co19#1392)
2022-08-11 sgrekhov22@gmail.com dart-lang/co19#1388. FFI test failures fixed (dart-lang/co19#1389)

Change-Id: I2eee6c193eed1ce8a511f3ef5667ded947fbfad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257700
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stereotype441 @sgrekhov