Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dart 3 dev CI builds #3422

Merged
merged 4 commits into from Dec 12, 2022
Merged

Fix Dart 3 dev CI builds #3422

merged 4 commits into from Dec 12, 2022

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Dec 12, 2022 •
edited

Closes #3421

  • Fix build_web_compilers test fixture sdk constraints to allow dart 3.x.
  • Add a test utility to check if unsound null safety is supported (sdk version is 2.x).
    • Use this utility to omit tests for unsound null safety features.
  • skip build_vm_compilers related tests on windows CI, there is some sort of issue related to crossing between drives

@jakemac53 jakemac53 marked this pull request as draft December 12, 2022 16:20
@jakemac53 jakemac53 changed the title Fix build_web_compilers test fixture sdk constraints to allow dart 3.x. Fix Dart 3 dev CI builds Dec 12, 2022
@jakemac53 jakemac53 marked this pull request as ready for review December 12, 2022 18:06
@jakemac53 jakemac53 merged commit 3797325 into master Dec 12, 2022
@jakemac53 jakemac53 deleted the dart-3-fixes branch December 12, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Dart 3.0 failures on CI
2 participants
@jakemac53 @natebosch