use TypeError instead of NullThrownError #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some additional failures due to unexpected output on stderr when running I will try to figure out the best way to resolve that. |
|
Filed dart-lang/sdk#50592 on the sdk, skipping these expectations for now. |
kevmoo
approved these changes
Nov 30, 2022
natebosch
approved these changes
Dec 1, 2022
natebosch
reviewed
Dec 2, 2022
| @@ -68,6 +68,9 @@ Future<void> _startServer(String command, List<String> buildArgs, | |||
| } | |||
|
|
|||
| final proc = _process = await Process.start(command, buildArgs); | |||
| unawaited(proc.exitCode.then((_) { | |||
There was a problem hiding this comment.
How did this come up? Was there a problem when the process died earlier than expected?
simolus3
pushed a commit
to simolus3/build
that referenced
this pull request
Dec 11, 2022
* use TypeError instead of NullThrownError * skip tests checking for no output on stderr until dart-lang/sdk#50592 is resolved * fix serve tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the dev bot failures