Report and shutdown after file watch errors #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Nov 21, 2022
jakemac53
reviewed
Nov 21, 2022
jakemac53
approved these changes
Nov 22, 2022
jakemac53
added a commit
that referenced
this pull request
Nov 30, 2022
simolus3
pushed a commit
to simolus3/build
that referenced
this pull request
Dec 11, 2022
* Report and shutdown after file watch errors * change error codes
simolus3
pushed a commit
to simolus3/build
that referenced
this pull request
Dec 11, 2022
…-lang#3415) This was removed in dart-lang#3395 but reverted in dart-lang#3411 (likely a bad merge). This just removes it again.
jakemac53
added a commit
that referenced
this pull request
Mar 10, 2023
Removes all methods from ChangeProvider, and extract only the relevant ones into separate subclasses which are now public (AutoChangeProvider vs ManualChangeProvider). Previously these modes were conflated and the different impls provided essentially no-op implementations of the non-applicable apis. This should fix the failures we are seeing on the bots, because the daemon was shutting down early due to an empty stream given by the manual change provider. This was broken in #3411, but we only recently published that change, and weren't using dependency overrides for the tests that were actually broken, so we only saw it after the publish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally we are seeing reliability issues with our file watcher. This should help diagnose the root cause.