Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix analyzer deprecations #3376

Merged
merged 3 commits into from Oct 4, 2022
Merged

fix analyzer deprecations #3376

merged 3 commits into from Oct 4, 2022

Conversation

jakemac53
Copy link
Contributor

cc @scheglov do I need to up these min sdk constraints or should I leave them?

@scheglov
Copy link
Contributor

scheglov commented Oct 3, 2022

Not sure why you asking me, you probably know this stuff better :-). For SDK constraints, we probably need to say that it is < 3.0.0. But we don't have to say >= 2.17.0 because at least the analyzer will require this, so I think you will not able to satisfy constraints on lower SDK versions anyway.

For analyzer constraints, analyzer: '>=5.1.0 <6.0.0' seems right to me, because you need >=5.1.0 to get new incarnation of get name.

@jakemac53
Copy link
Contributor Author

I think I need to update the sdk dependency to >=2.18.0 across the board here so we can get a package:test version that supports the latest analyzer

@jakemac53
Copy link
Contributor Author

@scheglov sorry I meant the min analyzer constraints, just had a brain fart :)

Thanks you answered my question for that, I will leave it at >=5.1.0

build_modules/mono_pkg.yaml Outdated Show resolved Hide resolved
@jakemac53 jakemac53 merged commit 9648eff into master Oct 4, 2022
@jakemac53 jakemac53 deleted the analyzer-deprecations branch October 4, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants