Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest package:analyzer #3368

Merged
merged 7 commits into from Sep 13, 2022
Merged

Support latest package:analyzer #3368

merged 7 commits into from Sep 13, 2022

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Sep 13, 2022

Prepare to publish several packages

Prepare to publish several packages
build/pubspec.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you should be able to remove the overrides?

@kevmoo
Copy link
Member Author

kevmoo commented Sep 13, 2022

LGTM but I think you should be able to remove the overrides?

I was going to before I publish. Should I land the PR w/out the overrides?

@jakemac53
Copy link
Contributor

I was going to before I publish. Should I land the PR w/out the overrides?

If they aren't needed I would yes - I realize now you probably did this to allow you to get the latest analyzer? But we can see its green so I would now revert and then land.

@jakemac53
Copy link
Contributor

jakemac53 commented Sep 13, 2022

Oh actually - it looks like you still did not get the latest analyzer (at least for some of the runs).

You might want to add an override to the latest analyzer to force it.

@jakemac53
Copy link
Contributor

Scratch my last comment - looks like the dev builds did pick it up

build_resolvers/pubspec.yaml Outdated Show resolved Hide resolved
build_runner_core/pubspec.yaml Outdated Show resolved Hide resolved
build_test/pubspec.yaml Outdated Show resolved Hide resolved
kevmoo and others added 3 commits September 13, 2022 10:21
Co-authored-by: Nate Bosch <nbosch@google.com>
Co-authored-by: Nate Bosch <nbosch@google.com>
Co-authored-by: Nate Bosch <nbosch@google.com>
@kevmoo
Copy link
Member Author

kevmoo commented Sep 13, 2022

Thanks @natebosch – copy/paste error

@kevmoo kevmoo merged commit 07d1aaf into master Sep 13, 2022
@kevmoo kevmoo deleted the latest_analyzer branch September 13, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants