Make package configuration loading use the correct function. #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have the URI of a package configuration file, you don't need to use package configuration discovery.
|
Please update changelog and pubspec too. |
jensjoha
approved these changes
Aug 17, 2022
|
Pubspec is at 2.1.6-dev. A bug-fix should be a safe addition to that release number, no need for a minor version increment. If we want to release, we have to remove the -dev, but probably also other things, like references to this package from other packages in the same mono-repo. I'd prefer to leave that to people who know the repo. CHANGELOG entry added. |
mit-mit
approved these changes
Aug 17, 2022
jakemac53
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have the URI of a package configuration file, you should load it directly.
It's not safe to use discovery, which assumes you start with a Dart script file.
Fixes #3354