Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow customized builder ordering by users #3334

Merged
merged 5 commits into from Jul 12, 2022

Conversation

jakemac53
Copy link
Contributor

Fixes #3328

@explodus did you want to try this out?

You should be able to add a dependency override like this to try it (in your pubspec.yaml):

dependency_overrides:
  build_config:
    git:
      url: https://github.com/dart-lang/build.git
      ref: allow-customizing-builder-ordering
      path: build_config
  build_runner:
    git:
      url: https://github.com/dart-lang/build.git
      ref: allow-customizing-builder-ordering
      path: build_runner

And then configure it like this in your build.yaml:

global_options:
  source_gen:combining_builder:
    runs_before:
      - reflectable

@jakemac53 jakemac53 requested a review from natebosch July 11, 2022 21:53
build_runner/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Nate Bosch <nbosch@google.com>
@jakemac53
Copy link
Contributor Author

cc @natebosch I added some validation of builder keys (when I was manually testing this feature I mistyped some... lol). I also prepped this for immediate release given that we have no other features planned.

@jakemac53 jakemac53 merged commit 5231292 into master Jul 12, 2022
@jakemac53 jakemac53 deleted the allow-customizing-builder-ordering branch July 12, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable consumers to configure builder ordering
2 participants