New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global analysis driver pool to protect usages #3313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we expand the commit message with 2 things:
- More details about why we need to guard access to reads from the driver.
- A rough sketch of the way the code is changing - in particular the nested function argument used to lock only part of the work.
scheglov
approved these changes
May 26, 2022
How does the updated text look? |
Looks great to me. Thanks! |
…ld_resolvers" This reverts commit 76f5bc3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3312
If the driver is used in between calls to
changeFile
and beforeapplyPendingChanges
completes, then you can getInconsistentAnalysisError
s. This change ensures we won't do that through a new single resource pool shared by all users of the driver.changeFile
calls and subsequent call toapplyPendingFileChanges
. This prevents deadlocks compared to a global resolution pool, which may call out topackage:build
apis which can deadlock._entryPoints
.