Remove tests that attempt to modify files #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #3202 Calling `MemoryResourceProvider.modifyFile` is not sufficient for the analyzer to respond to the changes, `AnalysisDriver.changeFile` is the important call, but we don't have access to that member from the tests. The real world behavior that would lead to this scenario requires more complex interactions we can do with `resolveSources`. Remove these tests entirely since they are not testing what they purport and are not useful as they stand.
jakemac53
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3202
Calling
MemoryResourceProvider.modifyFileis not sufficient for theanalyzer to respond to the changes,
AnalysisDriver.changeFileis theimportant call, but we don't have access to that member from the tests.
The real world behavior that would lead to this scenario requires more
complex interactions we can do with
resolveSources.Remove these tests entirely since they are not testing what they purport
and are not useful as they stand.