Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add performance tracking to all methods on PerActionResolver #3282

Merged
merged 1 commit into from Apr 13, 2022
Merged

add performance tracking to all methods on PerActionResolver #3282

merged 1 commit into from Apr 13, 2022

Conversation

jakemac53
Copy link
Contributor

This helps when trying to figure out where the time is going inside a builder (spawned from investigation into #3281)

natebosch
natebosch approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be worried about this making performance logs much longer?

@jakemac53
Copy link
Contributor Author

Should we be worried about this making performance logs much longer?

I don't think so, in general this is all only enabled if/when people pass --track-performance anyways. The web viewer did a good job of handling this for the case I was looking at, usually these calls are sequential so they end up in one row on the timeline all together.

@jakemac53 jakemac53 merged commit d927428 into master Apr 13, 2022
@jakemac53 jakemac53 deleted the track-resolver-calls branch April 13, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakemac53 @natebosch