Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report changed assets through build daemon #3273

Merged
merged 4 commits into from Mar 28, 2022

Conversation

simolus3
Copy link
Contributor

Report a list of changed assets (outputs + changed inputs from watcher) through the build daemon. Because this list can be rather large, the changes are only reported to clients actually interested in them.

Closes #3268.

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, otherwise this looks good to me.

We will also need to look internally and see if this affects things at all, although we can probably just not support the feature there.

@jakemac53
Copy link
Contributor

cc @grouma can you comment on the internal stuff before I try to do a roll?

@grouma
Copy link
Member

grouma commented Mar 25, 2022

I don't foresee any issues. In fact I vaguely recall that we wanted to add this kind of support a while back but it was never prioritized.

@jakemac53 jakemac53 merged commit f82f3dd into dart-lang:master Mar 28, 2022
@jakemac53
Copy link
Contributor

I will get an internal merge going here and then we can publish once that is successful

@simolus3 simolus3 deleted the daemon-changed-assets branch March 28, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of changed assets from daemon
3 participants