Use ??= over contains and ! for map defaulting
#3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid a non-null assertion by chaining access from a null conditional assignment instead of separately inserting to the map, then reading it back out for further operations. Also refactor an iterable `.toList()` to a List literal.
|
I noticed some stuff I could code-golf when I was trying to understand behavior, and after looking at it I think this is actually nicer despite being a bit dense. |
jakemac53
approved these changes
Jan 31, 2022
| librariesByDirectory[dir] = <AssetId, ModuleLibrary>{}; | ||
| } | ||
| librariesByDirectory[dir]![library.id] = library; | ||
| (librariesByDirectory[dir] ??= {})[library.id] = library; |
There was a problem hiding this comment.
we could use putIfAbsent also, but 🤷♂️
There was a problem hiding this comment.
Yeah, I had thought about that pattern too but for some reason ??= looked nicer to me.
Maybe it was something like dart2js emitting better code for ??= than putIfAbsent? (even though this will not be compiled with dart2js)
There was a problem hiding this comment.
I would usually use putIfAbsent, it's true that this doesn't require a closure though. I am fine with either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a non-null assertion by chaining access from a null conditional
assignment instead of separately inserting to the map, then reading it
back out for further operations.
Also refactor an iterable
.toList()to a List literal.