Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe build schema setup for common tools #3220

Merged
merged 3 commits into from Dec 2, 2021

Conversation

simolus3
Copy link
Contributor

@simolus3 simolus3 commented Dec 2, 2021

Closes #3217.

Maybe we want to encourage users to enable that for build.yaml files overriding packages too? I think all patterns would be build.yaml, *.build.yaml, build.*.yaml and *.build.*.yaml then, right? I'm not sure if the last one is valid (overriding a package only under a specific --config flag?).

@google-cla google-cla bot added the cla: yes Google is happy with the PR contributors label Dec 2, 2021
@jakemac53
Copy link
Contributor

I'm not sure if the last one is valid (overriding a package only under a specific --config flag?).

Haha, I don't know either 😆

@jakemac53
Copy link
Contributor

The linked image doesn't appear to work, but otherwise it looks good to me. Suggesting the other patterns also seems like a good idea (but maybe not the last one, haha).

@simolus3
Copy link
Contributor Author

simolus3 commented Dec 2, 2021

The linked image doesn't appear to work, but otherwise it looks good to me.

I think that may be GitHub resolving links in previews weirdly? It appears to work when viewed on the branch.

But I'll add the two other file patterns too.

@jakemac53
Copy link
Contributor

Thanks! I just used these instructions to set it up for myself and it was a breeze and its quite nice 👍

@jakemac53 jakemac53 merged commit bcab7b2 into dart-lang:master Dec 2, 2021
@simolus3 simolus3 deleted the build-yaml-verification-guide branch December 2, 2021 23:00
@kevmoo
Copy link
Member

kevmoo commented Dec 8, 2021

THIS IS AWESOME! Thank you, @simolus3 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.yaml schema
3 participants