Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: change elements equality check to overcome incorrect libs resolution #891

Merged
merged 3 commits into from Jun 20, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#855

@incendial incendial added this to the 5.0.0 milestone Jun 14, 2022
@incendial incendial self-assigned this Jun 14, 2022
@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 430

  • Total lines of source code: 7569

  • Total classes: 296

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1326.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #891 (4c6c3cc) into master (75e0fb7) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 4c6c3cc differs from pull request most recent head 68d2607. Consider uploading reports for the commit 68d2607 to get more accurate results

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage   87.37%   87.30%   -0.08%     
==========================================
  Files         283      280       -3     
  Lines        5997     5954      -43     
==========================================
- Hits         5240     5198      -42     
+ Misses        757      756       -1     
Impacted Files Coverage Δ
...ers/unused_code_analyzer/unused_code_analyzer.dart 98.87% <100.00%> (+0.12%) ⬆️
...ules_list/prefer_extracting_callbacks/visitor.dart 100.00% <0.00%> (ø)
...ist/prefer_extracting_callbacks/config_parser.dart 100.00% <0.00%> (ø)
...ng_callbacks/prefer_extracting_callbacks_rule.dart 100.00% <0.00%> (ø)
...nt_analyzer/base_visitors/source_code_visitor.dart
...rules/rules_list/avoid_banned_imports/visitor.dart
...void_banned_imports/avoid_banned_imports_rule.dart
...list/avoid_banned_imports/utils/config_parser.dart
...list/source_lines_of_code/source_code_visitor.dart 100.00% <0.00%> (ø)
...c/analyzers/lint_analyzer/rules/rules_factory.dart 94.31% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3442f8...68d2607. Read the comment docs.

@incendial incendial modified the milestones: 5.0.0, 4.16.0 Jun 16, 2022
@dkrutskikh dkrutskikh merged commit f49be8f into master Jun 20, 2022
@dkrutskikh dkrutskikh deleted the fix-unused-code-check-for-libraries branch June 20, 2022 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants