Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

feat: add static code diagnostic avoid-redundant-async #1002

Merged
merged 5 commits into from Sep 19, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

#113

@incendial incendial added type: enhancement New feature or request area-rules labels Sep 16, 2022
@incendial incendial added this to the 4.19.0 milestone Sep 16, 2022
@incendial incendial self-assigned this Sep 16, 2022
@github-actions
Copy link

github-actions bot commented Sep 16, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Sep 16, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 503

  • Total lines of source code: 8639

  • Total classes: 374

  • Average Cyclomatic Number per line of code: 0.36 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 2130.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1002 (305a3c1) into master (a254d6e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   87.41%   87.48%   +0.06%     
==========================================
  Files         313      315       +2     
  Lines        6620     6657      +37     
==========================================
+ Hits         5787     5824      +37     
  Misses        833      833              
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 71.42% <ø> (ø)
...id_redundant_async/avoid_redundant_async_rule.dart 100.00% <100.00%> (ø)
...ules/rules_list/avoid_redundant_async/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 3dd127e into master Sep 19, 2022
@incendial incendial deleted the implement-avoid-redundant-async branch September 19, 2022 18:02
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants