Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broken Website] GitHub online editor text area is white #12722

Open
2 tasks done
nic-obert opened this issue May 14, 2024 · 2 comments
Open
2 tasks done

[Broken Website] GitHub online editor text area is white #12722

nic-obert opened this issue May 14, 2024 · 2 comments

Comments

@nic-obert
Copy link

Prerequisites

  • I searched for any existing report about this website issue to avoid opening a duplicate.
  • I can reproduce this website issue in a new, unmodified web browser profile with Dark Reader installed as the only extension.

Website Issue Description

When editing a file on GitHub, using GitHub's online text editor, the unwritten part of the editor's text area is white.
The part of the text area that actually contains text (including newlines) is correctly displayed as black. However, the remaining portion of the text area, which doesn't contain any text, is displayed as white.

Website Address

https://github.com

Steps To Reproduce

  1. Open any file on GitHub in edit mode with the online text editor

Screenshots

dark_reader_white
ArcoLinux_2024-05-14_21-58-02

Operating System

ArcoLinux (arch-based) Kernel 6.8.9-arch1-2

Web Browser name and version

Google Chrome 124.0.6367.201

Dark Reader version

4.9.84

Additional Context

The problem persists after any combination of refreshing the page and disabling/enabling dark mode

@oberrich
Copy link
Contributor

oberrich commented May 15, 2024

Managed to reproduce on 4.9.84 and 4.9.85 (trunk).

.cm-scroller:before {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller:after {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller {
    background-color: var(--darkreader-neutral-background) !important;
}

This seemed to fix it for me, can you check if this works for you @nic-obert?

@nic-obert
Copy link
Author

nic-obert commented May 16, 2024

Managed to reproduce on 4.9.84 and 4.9.85 (trunk).

.cm-scroller:before {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller:after {
    background-color: var(--darkreader-neutral-background) !important;
}
.cm-scroller {
    background-color: var(--darkreader-neutral-background) !important;
}

This seemed to fix it for me, can you check if this works for you @nic-obert?

Pasting this CSS in the head > style.darkreader.darkreader--user-agent HTML element works perfectly. The entire editor text area is displayed as black as it should.

Edit:

I figured it would be nice to add a screenshot of the resulting page

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants