-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only serialize failure details if they exist #707
base: main
Are you sure you want to change the base?
only serialize failure details if they exist #707
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
==========================================
- Coverage 86.37% 86.29% -0.08%
==========================================
Files 79 82 +3
Lines 4094 4196 +102
==========================================
+ Hits 3536 3621 +85
- Misses 558 575 +17 ☔ View full report in Codecov by Sentry. |
Hey @akshaya-a , thanks for your PR. Could you please sign your commit? Here's how to do it: Rebase the branch If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing"). You should only do this if:
To add your Signed-off-by line to every commit in this branch:
|
I was able to reproduce this locally and test the fix. Looks good. I would love an added test for it, though. |
@akshaya-a please do the following or this cannot be merged. To add your Signed-off-by line to every commit in this branch: Ensure you have a local copy of your branch by checking out the pull request locally via command line. |
@elena-kolevska @berndverst sorry for the delay, was focused on some stuff for //build yeah the only reason I didn't bother signing yet was I assumed we'd want a test covering the failure but in my project I worked around it by just reaching in to the .__obj for debugging purposes, reducing the immediate priority i can probably get to this next week? |
1faf3cc
to
d2fe73e
Compare
Signed-off-by: Akshaya Annavajhala <akshaya-a@users.noreply.github.com>
* Pin workflow SDK 0.4.1 in example Signed-off-by: Bernd Verst <github@bernd.dev> * fix workflow dev version Signed-off-by: Bernd Verst <github@bernd.dev> * fix workflow example dependency Signed-off-by: Bernd Verst <github@bernd.dev> --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Akshaya Annavajhala <akshaya-a@users.noreply.github.com>
d2fe73e
to
c5323f1
Compare
ah didn't realize i already had a codespace for this repo, no need to be lazy - signed in case you want to merge, but happy to add a test later |
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #691
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: