New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test long vals #717
Test long vals #717
Conversation
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@tanvigour Please see this PR Draft ... |
closing this as a draft. |
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
=========================================
Coverage 78.19% 78.19%
Complexity 1117 1117
=========================================
Files 97 97
Lines 3417 3417
Branches 399 399
=========================================
Hits 2672 2672
Misses 547 547
Partials 198 198 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were there issues related to previously low TTL seen?
flaky test |
Partially fixes #725 |
* run IT test for long values Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Fix the class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * assert for all messages and fix class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * test for Long.MAX_VALUE Signed-off-by: tanvigour <tanvi.gour@gmail.com> * revert back long number and print Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix the typo Signed-off-by: tanvigour <tanvi.gour@gmail.com> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <tanvi.gour@gmail.com> * log some more data to debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * get the value from messages Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix long values assert Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * increasing TTL Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com>
* run IT test for long values Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Fix the class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * assert for all messages and fix class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * test for Long.MAX_VALUE Signed-off-by: tanvigour <tanvi.gour@gmail.com> * revert back long number and print Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix the typo Signed-off-by: tanvigour <tanvi.gour@gmail.com> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <tanvi.gour@gmail.com> * log some more data to debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * get the value from messages Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix long values assert Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * increasing TTL Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
* run IT test for long values Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Fix the class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * assert for all messages and fix class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * test for Long.MAX_VALUE Signed-off-by: tanvigour <tanvi.gour@gmail.com> * revert back long number and print Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix the typo Signed-off-by: tanvigour <tanvi.gour@gmail.com> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <tanvi.gour@gmail.com> * log some more data to debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * get the value from messages Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix long values assert Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * increasing TTL Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Signed-off-by: naah69 <nayan3480232@163.com>
* run IT test for long values Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Fix the class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * assert for all messages and fix class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * test for Long.MAX_VALUE Signed-off-by: tanvigour <tanvi.gour@gmail.com> * revert back long number and print Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix the typo Signed-off-by: tanvigour <tanvi.gour@gmail.com> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <tanvi.gour@gmail.com> * log some more data to debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * get the value from messages Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix long values assert Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * increasing TTL Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Signed-off-by: naah69 <nayan3480232@163.com>
Description
Fixing the long values Test ...
Ran it 4 times in Github, did not fail once.
Basically I believe the change was the TTL seconds to 30 instead of 1. We are not testing TTL in this test.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: