Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IntelliJ IT docs #705

Merged
merged 4 commits into from Mar 22, 2022
Merged

Add IntelliJ IT docs #705

merged 4 commits into from Mar 22, 2022

Conversation

mukundansundar
Copy link
Contributor

@mukundansundar mukundansundar commented Mar 15, 2022 •
edited

Signed-off-by: Mukundan Sundararajan msundar.ms@outlook.com

Description

Added docs in README to explain on how to run Integration tests. To be merged after #697 since this PR refers to a file local-test-mongo.yml created in that PR.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mukundansundar
add intellij IT docs
bc2aeac 
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
@mukundansundar mukundansundar changed the title Add intellij IT docs [WIP] Add intellij IT docs Mar 15, 2022
@mukundansundar mukundansundar added do-not-merge kind/documentation Improvements or additions to documentation labels Mar 15, 2022
DeepanshuA
DeepanshuA reviewed Mar 15, 2022
View reviewed changes
README.md Outdated
* [Docker Compose](https://docs.docker.com/compose/install/)
* [Docker Desktop](https://www.docker.com/products/docker-desktop)
* Bash shell
* In Windows use [WSL](https://docs.microsoft.com/en-us/windows/wsl/install)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to recommend for WSL2, as most of the folks in Dapr team with Windows machine seem to be using WSL2.
https://howto.lintel.in/wsl-vs-wsl-2-performance/
https://docs.microsoft.com/en-us/windows/wsl/compare-versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs it is given

New Linux installations will be set to WSL 2 by default, but the wsl --set-version command can be used to downgrade from WSL 2 to WSL 1 as well. To see whether your Linux distribution is set to WSL 1 or WSL 2, use the command: wsl -l -v.

I think the default installation is wsl2 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, as per docs that seems to be the case. I don't remember exact commands, but my default implementation was WSL1 when I had installed a month back. But, anyways, we have already used WSL2 in the documentation now.

mukundansundar and others added 2 commits March 15, 2022 14:39
@mukundansundar
use wsl2
35cb40b 
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
@mukundansundar
Merge branch 'master' into add-intellij-IT-docs
3690c3a
@mukundansundar mukundansundar changed the title [WIP] Add intellij IT docs Add intellij IT docs Mar 17, 2022
@mukundansundar mukundansundar changed the title Add intellij IT docs Add IntelliJ IT docs Mar 17, 2022
@mukundansundar mukundansundar marked this pull request as ready for review March 17, 2022 15:38
@mukundansundar mukundansundar requested review from a team as code owners March 17, 2022 15:38
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #705 (178b5b1) into master (593da48) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #705      +/-   ##
============================================
+ Coverage     77.98%   78.10%   +0.11%     
- Complexity     1105     1106       +1     
============================================
  Files            97       97              
  Lines          3407     3407              
  Branches        394      394              
============================================
+ Hits           2657     2661       +4     
+ Misses          550      547       -3     
+ Partials        200      199       -1
Impacted Files Coverage Δ
sdk/src/main/java/io/dapr/utils/Retry.java 75.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593da48...178b5b1. Read the comment docs.

@artursouza artursouza merged commit 4365862 into dapr:master Mar 22, 2022
@artursouza artursouza added this to the v1.5 milestone Mar 22, 2022
@mukundansundar mukundansundar deleted the add-intellij-IT-docs branch March 22, 2022 04:08
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
Add IntelliJ IT docs (dapr#705)
a00dcfc 
* add intellij IT docs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* use wsl2

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
Add IntelliJ IT docs (dapr#705)
89e5955 
* add intellij IT docs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* use wsl2

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
Add IntelliJ IT docs (dapr#705)
5b67c77 
* add intellij IT docs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* use wsl2

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
Add IntelliJ IT docs (dapr#705)
c9870bc 
* add intellij IT docs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* use wsl2

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@mukundansundar
Add IntelliJ IT docs (dapr#705)
e13d400 
* add intellij IT docs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* use wsl2

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
artursouza pushed a commit to pkedy/java-sdk that referenced this pull request Jun 22, 2022
@mukundansundar @artursouza
Add IntelliJ IT docs (dapr#705)
741980d 
* add intellij IT docs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* use wsl2

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepanshuA DeepanshuA DeepanshuA left review comments

@artursouza artursouza artursouza approved these changes

@tanvigour tanvigour tanvigour approved these changes

Assignees
No one assigned
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mukundansundar @artursouza @DeepanshuA @tanvigour