Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Service invocation path segments automatic encode of / into %2f #702

Closed
mukundansundar opened this issue Mar 14, 2022 · 0 comments · Fixed by #697
Closed

Fix Service invocation path segments automatic encode of / into %2f #702

mukundansundar opened this issue Mar 14, 2022 · 0 comments · Fixed by #697
Assignees
Milestone

Comments

@mukundansundar
Copy link
Contributor

mukundansundar commented Mar 14, 2022

Expected Behavior

Given a method name containing "/" in service invocation, properly split path segments and call dapr.

Actual Behavior

Currently in PubSub IT,
https://github.com/dapr/java-sdk/blob/master/sdk-tests/src/test/java/io/dapr/it/pubsub/http/PubSubIT.java#L396-L400

The method being called is messages/ttlTopic which gets encoded as messages%2fttlTopic which was working prior to fix dapr/dapr#4008.

With the fix merged to Dapr, on Feb 8th, any build of Dapr after that fails the PubSub IT since it tries to invoke http://...../messages%2fttltopic instead of http://..../messages/ttlTopic.

See https://github.com/dapr/java-sdk/runs/5533656018?check_suite_focus=true#step:20:6305

Steps to Reproduce the Problem

Change Dapr Ref in build.yaml to any latest master ref from dapr/dapr and run the ITs.

Release Note

RELEASE NOTE: Fix service invocation path segments to avoid automatic encoding of / to %2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant