Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability in kafka-pubsub to send trace state to metadata as an option #3323

Open
passuied opened this issue Jan 26, 2024 · 6 comments
Open
Labels
kind/enhancement New feature or request

Comments

@passuied
Copy link
Contributor

passuied commented Jan 26, 2024

Describe the feature

PubSub components promote the usage of CloudEvents to include additional information in the message, including tracing information.
However, when working with existing events that do not use Cloud Events, you are losing the ability to having tracing. In some cases, when using Schema Registry, using cloud events is not an option at all... It would be a great option to be able to pass tracing information within the header. Kafka provides headers and currently any metadata added to the pubsub will be passed on as headers in the message.

I suggest providing an option in the Kafka subscription metadata to include tracing info as header automatically.

Release Note

RELEASE NOTE: ADD an option in Kafka PubSub subscription metadata to publish the tracing information as message headers

@passuied passuied added the kind/enhancement New feature or request label Jan 26, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 25, 2024
@passuied
Copy link
Contributor Author

Still planning to work on this. Just didn't get a chance yet

@yaron2 yaron2 removed the stale label Feb 29, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 30, 2024
@passuied
Copy link
Contributor Author

Based on looking at code it would require to create a span and inject to metadata when publishing a raw payload but that code is in Dapr. Should we move it to Dapr kit instead?

@github-actions github-actions bot removed the stale label Mar 30, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 29, 2024
Copy link

github-actions bot commented May 6, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@yaron2 yaron2 reopened this May 6, 2024
@github-actions github-actions bot removed the stale label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants