Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EventGrid component implementation to use the new Azure SDK with data polling #3322

Open
berndverst opened this issue Jan 25, 2024 · 5 comments
Assignees
Labels
kind/enhancement New feature or request pinned Issue does not get stale

Comments

@berndverst
Copy link
Member

At the time of the EventGrid component creation there was no Go SDK for it. We had to use an ARM Management SDK, and only delivery via a public endpoint (pushing of events) was supported as a result. This was complicated to configure for users.

Now there is a GO SDK that supports polling. We should rewrite the component to use the official Go SDK. This would be vastly more convenient and secure for users.

https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/messaging/azeventgrid

@denniszielke
Copy link
Member

Agree. That would have helped us in a couple engagements.
Relevant would on how batching could be used and how would dapr handle accepting/ rejecting individual events?
Also great if there would be a metric that could be used to monitor the number of batches.

@berndverst
Copy link
Member Author

berndverst commented Feb 9, 2024

@denniszielke

PubSub

support for a native Batch/Bulk subscription would not be part of this switch in the PubSub component and that would need to come in a subsequent implementation.

Maybe we would release this updated component as a v2 so that we can retain the existing behavior as a v1 component (with no further updates however). The v2 version with polling would lack support for native bulk / batch initially. This would be a subsequent feature someone can add. You can read up on Dapr Bulk Pubsub on the Dapr docs. This is how we would need to implement bulk / batch handling.

Binding

As for the switching the Binding to the new SDK and support Batch/Bulk there. This could be implemented more freely - and suggestions or contributions are welcome here. (You will need to check the specific SDK capabilities) There is no precedent that must be followed.

Note on the Event Grid Go SDK

Because the Event Grid SDK is not v1.0 yet I will insistent on labeling these components Alpha or Beta (meaning they do not get patch/hotfix support in Dapr) until we have a stable SDK from the Azure SDK for Go team.

Expectation Setting

I do want to set realistic expectations that all of this is more of a wish list / dream I would like to see as maintainer. But neither I or anyone I'm aware of have time and resources to implement this. Contributions are welcome of course.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 10, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2024
@yaron2 yaron2 reopened this Mar 17, 2024
@github-actions github-actions bot removed the stale label Mar 17, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 16, 2024
@ItalyPaleAle ItalyPaleAle added pinned Issue does not get stale and removed stale labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request pinned Issue does not get stale
Projects
None yet
Development

No branches or pull requests

4 participants