Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assets to a "assets" directory #185

Open
sebdiem opened this issue Oct 24, 2020 · 4 comments
Open

Move assets to a "assets" directory #185

sebdiem opened this issue Oct 24, 2020 · 4 comments
Labels
enhancement New feature or request someday Not planned to do in the near future, mostly due to limited resources

Comments

@sebdiem
Copy link
Contributor

sebdiem commented Oct 24, 2020

Wow this is a great project ! It really simplifies my workflow to share data science notebooks.
Would it be possible to "tidy" the assets in a dedicated folder so that the index.html is more accessible when exporting to folder ?
This would simplify sharing with non tech-savy users.

Thanks for the great work !

@danny0838
Copy link
Owner

danny0838 commented Oct 24, 2020

Adding another folder makes file deduplication and interlinking much more difficult as all relative links need to be tweaked and be really taken care. For example, to link from index.html to assets/*, from assets/frame1.html to assets/bar.png, assets/frame1.html to index.html, index.html to assets/frame1.html, assets/frame1.html to assets/frame2.html, etc.

Another issue to to keep backward compatibility with legacy ScrapBook.

We may implement it in the future if all such issues can be resolved... but not likely for now.

@danny0838 danny0838 added the enhancement New feature or request label Oct 24, 2020
@sebdiem
Copy link
Contributor Author

sebdiem commented Oct 24, 2020

thank you for your precise answer

@chrizilla
Copy link

Thank you for your great extension! 👍

but not likely for now.

I understand that it may not be trivial, but please keep this request in mind for the future, because the tidy folder structure of the Firefox MAF addon is really much more advantageous.

@Knocks
Copy link

Knocks commented Aug 24, 2023

Separating assets is not just for aesthetics or making it easier for non-tech users. It also allows to merge identical assets if you are saving multiple pages from the same domain. That also makes find and replace much easier in the future if you need to manipulate these asset locations.

Ideally, images, CSS, scripts etc and the index file should all be separate.

If backwards compatibility is a concern, the option can simply be enabled by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request someday Not planned to do in the near future, mostly due to limited resources
Projects
None yet
Development

No branches or pull requests

4 participants