Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add to the options the ability to customize menu items #148

Open
wisiwig opened this issue Apr 15, 2020 · 6 comments
Open
Labels
duplicate This issue or pull request already exists enhancement New feature or request someday Not planned to do in the near future, mostly due to limited resources

Comments

@wisiwig
Copy link

wisiwig commented Apr 15, 2020

  • Provide the user with the opportunity to choose which menu items will appear in the pop-up menu when the extension button is pressed.
  • Also add the option to remove the extension from the context menu (right mouse button).
@andrewchenshx
Copy link

andrewchenshx commented Apr 15, 2020 via email

@danny0838 danny0838 added the enhancement New feature or request label Apr 15, 2020
@danny0838
Copy link
Owner

danny0838 commented Apr 17, 2020

@wisiwig

Provide the user with the opportunity to choose which menu items will appear in the pop-up menu when the extension button is pressed.

@andrewchenshx

Furthermore, I wish the item in the edit toolbar can be configured, and the toolbar will popup near the selection.

Can you provide a good reason why such feature is needed? They are technically implementable but kind of trivial and we currently don't see a good reason to implement them.

@andrewchenshx
Copy link

such that your reading/annotating flow will not be disrupted by moving cursor between selection and the faraway editor toolbar, so the experience is smoother

@danny0838
Copy link
Owner

@andrewchenshx My bad, but I meant to ask about this:

I wish the item in the edit toolbar can be configured

Which has not been provided in your description.

@andrewchenshx
Copy link

Sorry.
My philosophy is to keep it simple and clean. Less items means less disruption, so u focus on reading.
Actually, I hope , after selection there are only two items appear on the floating editor toolbar , one for highlighting and another for annotating .

@danny0838
Copy link
Owner

Implemented context menu config in 0.68.0 (also duplicate with #49)

@danny0838 danny0838 added the duplicate This issue or pull request already exists label Apr 17, 2020
@danny0838 danny0838 added the someday Not planned to do in the near future, mostly due to limited resources label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request someday Not planned to do in the near future, mostly due to limited resources
Projects
None yet
Development

No branches or pull requests

3 participants