Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport django-storages gcloud upload and acl double requests. #36

Closed
Natim opened this issue May 16, 2019 · 0 comments · Fixed by #37
Closed

Backport django-storages gcloud upload and acl double requests. #36

Natim opened this issue May 16, 2019 · 0 comments · Fixed by #37

Comments

@Natim
Copy link
Contributor

Natim commented May 16, 2019

Our current implementation does two calls, one to upload the file and one to fix the ACL.

This leads to a large number of 503.

We had the issue with django-storages and one fix was to upload the file and change the ACL at the same time. (jschneier/django-storages#698
)

I suggest we backport this change here too.
@Natim Natim changed the title Backport django-storages acl fixes Backport django-storages gcloud upload and acl double requests. May 16, 2019
Natim pushed a commit to Natim/pyramid_storage that referenced this issue May 16, 2019
Merge file upload and acl requests for Gcloud.
f1ae2d0 
Fixes danjac#36
Refs https://github.com/jschneier/django-storages/pull/698/files
@Natim Natim mentioned this issue May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge file upload and acl requests for Gcloud. Natim/pyramid_storage
1 participant
@Natim