Only skip the found line, not the whole file #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for you PR. Will have a look next week. |
|
Thanks again. I just merged your PR. The next release will contain the fix (not sure when I will publish it). |
obergerdavid
deleted the
feature/fix_sonarcube_coverage_when_using_multiple_input_files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple coverage reports as input for the SonarQube format, then the coverage is not correctly merged.
The reason for this is that the SonarCubeBuilder skips the whole file if an existing line is found in an existing file.
With this PR this behavior is fixed, so that only the existing line is not added a second time.