Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color change of header rows for dark mode preference users #461

Merged
merged 1 commit into from Nov 6, 2021
Merged

Conversation

Throwy
Copy link
Contributor

@Throwy Throwy commented Nov 6, 2021

Let me start out by saying that I love this tool.

I've recently started using it to generate reports on code coverage. One thing stood out to me though. When dark mode preference is set in the browser and the report loads in dark mode, the header rows for namespaces are a really light color. (I think it was just missed probably) like in this screenshot.
before-style-fix
.

With my change I believe I have fixed the issue
after_style_fix
.

If you could take a look at this, I would greatly appreciate it. And I'm open to any suggestions on what else I can do.

Thanks!

@danielpalme danielpalme merged commit 2eccd5e into danielpalme:master Nov 6, 2021
@danielpalme
Copy link
Owner

Thanks for you PR.
You are right, that css rule was missing.

I will release a new version by the end of next week.

@Throwy
Copy link
Contributor Author

Throwy commented Nov 6, 2021

Awesome. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants