Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A dark theme support #203

Closed
moikot opened this issue Jan 24, 2019 · 9 comments
Closed

A dark theme support #203

moikot opened this issue Jan 24, 2019 · 9 comments

Comments

@moikot
Copy link

moikot commented Jan 24, 2019

ReportGeneraor is a nice tool and helps me a lot but I'm using a dark theme in Azure Devops and it would be nice to have dark theme support in the generator too.

@danielpalme
Copy link
Owner

Will add support for this in the next days.

@moikot
Copy link
Author

moikot commented Jan 24, 2019

Awesome! Thank you!

@danielpalme
Copy link
Owner

I assume you are using the Azure DevOps extension?

I just published an update (version 1.0.19). It should be available within the next minutes.

If you want to use the dark theme, you have to change the setting "Report types" from HtmlInline_AzurePipelines to HtmlInline_AzurePipelines_Dark

image

Or in your YAML file:

- task: Palmmedia.reportgenerator.reportgenerator-build-release-task.reportgenerator@1
  displayName: ReportGenerator
  inputs:
    reports: 'src\target\reports\coverage\coverage.opencover.xml'
    targetdir: 'src\target\reports\coverage'
    reporttypes: 'HtmlInline_AzurePipelines_Dark;Cobertura'

Does this work for you?

danielpalme added a commit that referenced this issue Jan 26, 2019
@moikot
Copy link
Author

moikot commented Jan 26, 2019

It's quite confusing but unfortunately I can't use the extension due to company policies. I'm running it using a Docker image (Dockerfile). Nevertheless, I tested the new theme and it's looking great! Thank you!

Just one thing came to my mind, you have to choose the theme (normal/dark) when you generate a report but the users who view the report afterwards might have different preferences. I'm not sure if it's possible to dynamically select the theme for a particular user.

@danielpalme
Copy link
Owner

Switching the theme based on user preference is not possible. Ayure DevOps blocks all JavaScript content, so there's no way to switch.

@moikot
Copy link
Author

moikot commented Jan 26, 2019

I see, it's a bit unfortunate. Thank you anyway for implementing the feature!

@moikot moikot closed this as completed Jan 26, 2019
@fchiumeo
Copy link

when a version will be available in nuget?
nuget version is 4.0.9

@danielpalme
Copy link
Owner

Within the next days. I want to integrate #205 first before publishing a new release.

@danielpalme
Copy link
Owner

New release should be available within the next minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants