From 55c5343afe79e43ba4c3a829a90f2ca8c7a43ad9 Mon Sep 17 00:00:00 2001 From: Daniel Prilik Date: Wed, 17 Aug 2022 09:03:14 -0700 Subject: [PATCH] 1.63 clippy lints --- gdbstub_arch/src/riscv/reg/riscv.rs | 2 +- gdbstub_arch/src/x86/reg/core32.rs | 2 +- gdbstub_arch/src/x86/reg/core64.rs | 2 +- gdbstub_arch/src/x86/reg/mod.rs | 4 ++-- src/stub/core_impl.rs | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdbstub_arch/src/riscv/reg/riscv.rs b/gdbstub_arch/src/riscv/reg/riscv.rs index 9875ad2d..15075f22 100644 --- a/gdbstub_arch/src/riscv/reg/riscv.rs +++ b/gdbstub_arch/src/riscv/reg/riscv.rs @@ -10,7 +10,7 @@ use gdbstub::internal::LeBytes; /// Useful links: /// * [GNU binutils-gdb XML descriptions](https://github.com/bminor/binutils-gdb/blob/master/gdb/features/riscv) /// * [riscv-tdep.h](https://github.com/bminor/binutils-gdb/blob/master/gdb/riscv-tdep.h) -#[derive(Debug, Default, Clone, PartialEq)] +#[derive(Debug, Default, Clone, PartialEq, Eq)] pub struct RiscvCoreRegs { /// General purpose registers (x0-x31) pub x: [U; 32], diff --git a/gdbstub_arch/src/x86/reg/core32.rs b/gdbstub_arch/src/x86/reg/core32.rs index 91c94c21..105b3800 100644 --- a/gdbstub_arch/src/x86/reg/core32.rs +++ b/gdbstub_arch/src/x86/reg/core32.rs @@ -8,7 +8,7 @@ use super::{X86SegmentRegs, X87FpuInternalRegs, F80}; /// /// Source: /// Additionally: -#[derive(Debug, Default, Clone, PartialEq)] +#[derive(Debug, Default, Clone, PartialEq, Eq)] pub struct X86CoreRegs { /// Accumulator pub eax: u32, diff --git a/gdbstub_arch/src/x86/reg/core64.rs b/gdbstub_arch/src/x86/reg/core64.rs index b6ae3233..f61d2d54 100644 --- a/gdbstub_arch/src/x86/reg/core64.rs +++ b/gdbstub_arch/src/x86/reg/core64.rs @@ -8,7 +8,7 @@ use super::{X86SegmentRegs, X87FpuInternalRegs, F80}; /// /// Source: /// Additionally: -#[derive(Debug, Default, Clone, PartialEq)] +#[derive(Debug, Default, Clone, PartialEq, Eq)] pub struct X86_64CoreRegs { /// RAX, RBX, RCX, RDX, RSI, RDI, RBP, RSP, r8-r15 pub regs: [u64; 16], diff --git a/gdbstub_arch/src/x86/reg/mod.rs b/gdbstub_arch/src/x86/reg/mod.rs index 64d0afa7..6397e701 100644 --- a/gdbstub_arch/src/x86/reg/mod.rs +++ b/gdbstub_arch/src/x86/reg/mod.rs @@ -17,7 +17,7 @@ pub use core64::X86_64CoreRegs; pub type F80 = [u8; 10]; /// FPU registers -#[derive(Debug, Default, Clone, PartialEq)] +#[derive(Debug, Default, Clone, PartialEq, Eq)] pub struct X87FpuInternalRegs { /// Floating-point control register pub fctrl: u32, @@ -92,7 +92,7 @@ impl Registers for X87FpuInternalRegs { /// x86 segment registers. /// /// Source: -#[derive(Debug, Default, Clone, PartialEq)] +#[derive(Debug, Default, Clone, PartialEq, Eq)] pub struct X86SegmentRegs { /// Code Segment pub cs: u32, diff --git a/src/stub/core_impl.rs b/src/stub/core_impl.rs index ed2a06ea..31ab884c 100644 --- a/src/stub/core_impl.rs +++ b/src/stub/core_impl.rs @@ -218,7 +218,7 @@ impl GdbStubImpl { // return a dummy stop reason. if target.base_ops().resume_ops().is_none() && target.use_resume_stub() { let is_resume_pkt = cmd - .get(0) + .first() .map(|c| matches!(c, b'c' | b'C' | b's' | b'S')) .unwrap_or(false);