Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsome dependency #914

Closed
mathiashoeld opened this issue Aug 28, 2019 · 4 comments
Closed

Remove jsome dependency #914

mathiashoeld opened this issue Aug 28, 2019 · 4 comments
Labels
You Can Do This This idea is well spec'd and ready for a PR

Comments

@mathiashoeld
Copy link

The npm package mem is marked as security vulnerability by Github. The package is a dependency of os-locale which is a dependency of yargs which is a dependency of jsome which has not been updated for 2 years, i.e. it is not likely that the yargs dependency will be updated anytime soon. (See this issue for reference)

To remove this security vulnerability it would be ideal to remove the dependency on jsome since it is probably only used only for styling the json output.

@mathiashoeld mathiashoeld changed the title Remove or update jsome dependency Remove jsome dependency Aug 28, 2019
@orta
Copy link
Member

orta commented Aug 28, 2019

Happy to have that switched out with something similar 👍

@orta orta added the You Can Do This This idea is well spec'd and ready for a PR label Aug 28, 2019
@orta
Copy link
Member

orta commented Sep 1, 2019

https://github.com/rafeca/prettyjson could do it

watchinharrison added a commit to watchinharrison/danger-js that referenced this issue Sep 24, 2019
repalce jsome with prettyjson
removes security issue with sub deps of jsome
watchinharrison added a commit to watchinharrison/danger-js that referenced this issue Sep 24, 2019
repalce jsome with prettyjson
removes security issue with sub deps of jsome
peril-staging bot added a commit that referenced this issue Sep 24, 2019
(#914) replace jsome
@platan
Copy link

platan commented Oct 23, 2019

I think this issue was resolved by #920. Can we close it?

@orta
Copy link
Member

orta commented Oct 23, 2019

Ace, sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
You Can Do This This idea is well spec'd and ready for a PR
Projects
None yet
Development

No branches or pull requests

3 participants