Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Danger Ignore not working on Gitlab - Tried different formats #1379

Open
kadoshms opened this issue Apr 20, 2023 · 6 comments
Open

[BUG] Danger Ignore not working on Gitlab - Tried different formats #1379

kadoshms opened this issue Apr 20, 2023 · 6 comments

Comments

@kadoshms
Copy link

Describe the bug

Iv'e already seen this on danger/danger#650 but since it's an old one, I couldn't find any more references.
On an on prem Gitlab instancte, I am trying to ignore a specific fail. Danger message (original message changed):

"This action is forbidden"

Me trying the following variations:

Danger: Ignore "This action is forbidden"
> Danger: Ignore "This action is forbidden".

Also tested the Regex from this PR on my ignore message danger/danger#652 in it matched.
Is ignoring specific errors possible?
The danger docs say it is, although I couldn't find an evidence it actually works.

@kadoshms kadoshms added the bug label Apr 20, 2023
@orta
Copy link
Member

orta commented Apr 20, 2023

This feature only exists in the ruby version ( danger/danger) and not in the JS version (which we're on)

@kadoshms
Copy link
Author

Are there any plans to implement this?

@orta
Copy link
Member

orta commented Apr 20, 2023

Not from me, I'm not really convinced it's a great idea as a PR is very transitory thing

@kadoshms
Copy link
Author

Well I truly believe this is something that is worth considering, even as a configurable item.

@fbartho
Copy link
Member

fbartho commented Apr 21, 2023

I too am worried that Danger Ignore is a misfeature.

Coarse Workaround: you can control if your Dangerfile submits a violation by looking at your PR's labels (from your Dangerfile).

So we have various Feature-flags that control each chunk of custom Dangerfile logic, and you could enable/disable those in bulk via label.

@kadoshms
Copy link
Author

I indeed ended up creating a mechanism for skipping rules via Labels, works pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants