Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsonwebtoken and @types/jsonwebtoken #1345

Merged
merged 1 commit into from Jan 5, 2023
Merged

Conversation

connyay
Copy link
Contributor

@connyay connyay commented Dec 27, 2022

  • Upgrade jsonwebtoken to ^9.0.0
  • Upgrade @types/jsonwebtoken to ^9.0.0

jsonwebtoken <= 8.5.1 had a potential vuln in the verify method
that wasn't called by this lib, but can still set off alerts
of vuln scanning tools

https://git.corp.tanium.com/advisories/GHSA-27h2-hvpr-p74q
https://git.corp.tanium.com/advisories/GHSA-8cf7-32gw-wr33

- Upgrade jsonwebtoken to ^9.0.0
- Upgrade @types/jsonwebtoken to ^9.0.0

jsonwebtoken <= 8.5.1 had a potential vuln in the verify method
that wasn't called by this lib, but can still set off alerts
of vuln scanning tools

https://git.corp.tanium.com/advisories/GHSA-27h2-hvpr-p74q
https://git.corp.tanium.com/advisories/GHSA-8cf7-32gw-wr33
@jeanphilippeds
Copy link

Thanks for the PR @connyay

What is the next step to have it merged?

Thanks,
JP

@connyay
Copy link
Contributor Author

connyay commented Jan 3, 2023

Thanks for the PR @connyay

What is the next step to have it merged?

Thanks, JP

🤷

A maintainer needs to approve/merge it.

@alexgleason
Copy link

alexgleason commented Jan 5, 2023

Fixes #1346

@orta Please merge this. It fixes... 4 security vulnerabilities. I just wasted time creating an MR only to discover it had already been done.

EDIT: I just sponsored from @soapbox-pub

@orta
Copy link
Member

orta commented Jan 5, 2023

Sure, will try make a deploy this evening - no need to sponsor for this though

@orta orta merged commit 64d9833 into danger:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants