Gitlab: added environment variable DANGER_SKIP_WHEN_EMPTY #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankatliarchuk
changed the title
ivankatliarchuk
changed the title
|
@orta would you be able to have a look? |
orta
reviewed
Nov 1, 2022
| @@ -67,7 +67,7 @@ getRuntimeCISource(app).then(source => { | |||
| if (!platform) { | |||
| console.log(chalk.red(`Could not find a source code hosting platform for ${source.name}.`)) | |||
| console.log( | |||
| `Currently Danger JS only supports GitHub and BitBucket Server, if you want other platforms, consider the Ruby version or help out.` | |||
| `Platform '${source.name}' is not supported with Danger JS, if you want other platforms, consider the Ruby version or help out.` | |||
|
Please don't ping me because I didn't do open source in my spare time on the weekends - that said, this looks good to me, nice work. |
|
Sure. Apologies. I think it was Monday, but probably your are in a different time zone :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found no issues or messages from Danger. Removing any existing messages on Gitlab.#1330