Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1301: Migrate gitlab to a new home #1318

Merged
merged 10 commits into from Oct 1, 2022
Merged

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Oct 1, 2022

Move GitLab dependency to a new home.
Migrate to a non-breaking version.
Relates: #1301
Relates: #1155

The latest version 35.7.0 contains just too many changes, to migrate in a single go.

package.json Show resolved Hide resolved
@ivankatliarchuk
Copy link
Contributor Author

Do I need to include yarn.lock to MR or not?

@emmesbef
Copy link

emmesbef commented Oct 1, 2022

yarn.lock should be always in sync with the package.json in my opinion

@ivankatliarchuk ivankatliarchuk changed the title Migrate gitlab to a new home issue-1301: Migrate gitlab to a new home Oct 1, 2022
@ivankatliarchuk
Copy link
Contributor Author

yarn.lock should be always in sync with the package.json in my opinion

Added yarn. Not always the case do. I would prefer automation to genearte .lock files on build/release

@ivankatliarchuk
Copy link
Contributor Author

Hi, @orta . Would it be possible to review this pr when you have time pls?

@ivankatliarchuk
Copy link
Contributor Author

Will have a look at what's going on with proxy-agent

@orta
Copy link
Member

orta commented Oct 1, 2022

It was a bad merge via the GitHub website - I cleaned it up locally 👍🏻

@orta
Copy link
Member

orta commented Oct 1, 2022

Yeah, though, this all does look good to me!

@orta orta merged commit 8e58eae into danger:main Oct 1, 2022
@ivankatliarchuk ivankatliarchuk deleted the issue_1301 branch October 1, 2022 15:56
@glensc glensc assigned glensc and unassigned glensc Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants