Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade proxy agents #1307

Merged
merged 3 commits into from Oct 1, 2022
Merged

Conversation

OscarBarrett
Copy link
Contributor

Resolves #1155
Related to #1169

Summary of changes

  • Upgraded http-proxy-agent to ^5.0.0
  • Upgraded https-proxy-agent to ^5.0.1
  • Removed replaced types: @types/http-proxy-agent (types are now self contained)
  • Removed replaced type declaration for https-proxy-agent
  • Removed use of new for agent initialization
  • Work around private property access in tests by using string index notation for agent['proxy']

- Upgraded http-proxy-agent to ^5.0.0
- Upgraded https-proxy-agent to ^5.0.1
- Removed replaced types: @types/http-proxy-agent
- Removed replaced type declaration for https-proxy-agent
- Removed use of new for agent initialization
- Work around private property access in testsby using string index notation for agent['proxy']
@OscarBarrett
Copy link
Contributor Author

FYI: My reason for PRing this is separate from the linked issue, but is due to incompatibility with node 16 on a custom Bitbucket Pipelines Runner.

The current version errors with:

class HttpProxyAgent extends agent_base_1.Agent {
                                          ^
TypeError: Class extends value undefined is not a constructor or null
    at Object.<anonymous> (/opt/atlassian/pipelines/agent/build/node_modules/http-proxy-agent/dist/agent.js:31:43)
    at Module._compile (node:internal/modules/cjs/loader:1126:14)
    ...

@orta
Copy link
Member

orta commented Oct 1, 2022

👍🏻 this looks good to me, thanks!

@orta orta merged commit f5eeee0 into danger:main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to use got or any got dependent libraries due to outdated https-proxy-agent
2 participants