Make BitBucket Server username matching case insensitive #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBrunow
commented
Jul 22, 2022
| @@ -213,7 +213,7 @@ export class BitBucketServerAPI implements BitBucketServerAPIDSL { | |||
|
|
|||
| return comments | |||
| .filter(comment => comment!.text.includes(dangerIDMessage)) | |||
| .filter(comment => username || comment!.author.name === username) | |||
There was a problem hiding this comment.
I'm not sure the history behind the username || part of this code but it does not seem like the proper logic? Happy to revert removing it if I need to.
There was a problem hiding this comment.
Yeah, I can't figure it out either, so lets take it and see
DavidBrunow
commented
Jul 22, 2022
| @@ -241,6 +241,49 @@ describe("API testing - BitBucket Server", () => { | |||
| ]) | |||
| }) | |||
|
|
|||
| it("getDangerCommentsCaseInsensitive", async () => { | |||
There was a problem hiding this comment.
I added extra tests rather than changing the existing tests to have case differences in the usernames. I went this way to it is more obvious why the usernames don't match perfectly but I'm happy to make changes to go any other direction.
f-meloni
reviewed
Jul 22, 2022
|
👍🏻 |
|
I have to release on a mac nowadays, so nextx time I'm on one I'll ship a build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1290.