Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Danger to find its own inline comment with an exact ID match #1287

Merged
merged 1 commit into from Jul 5, 2022

Conversation

nsugiyam
Copy link
Contributor

@nsugiyam nsugiyam commented Jul 5, 2022

Fixed a bug where Danger would delete inline comments posted by other Danger with the same prefix ID.

Same logic as getDangerCommentIDs().

.filter(comment => comment.body.includes(dangerIDMessage)) // does it contain the right danger ID?

@nsugiyam nsugiyam changed the title Fixed Danger to find its own inline comment with an exact ID match Fix Danger to find its own inline comment with an exact ID match Jul 5, 2022
@nsugiyam nsugiyam force-pushed the fix/github-inline-comment-id branch from a54a1a4 to a5932f0 Compare July 5, 2022 15:42
@orta
Copy link
Member

orta commented Jul 5, 2022

Ah, I see:

export const dangerIDToString = (id: string) => `danger-id-${id};`

Adds a semi at the end which would break and substring matches 👍🏻

@orta orta merged commit 45f2e97 into danger:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants