Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Create arm64 binary for Homebrew #1282

Closed
417-72KI opened this issue May 31, 2022 · 5 comments
Closed

[Feature] Create arm64 binary for Homebrew #1282

417-72KI opened this issue May 31, 2022 · 5 comments

Comments

@417-72KI
Copy link
Member

danger-js binaries installed via Homebrew are built in x86_64 architecture.

It causes danger/swift#464.

We need arm64 binary for M1 macs.

@fbartho
Copy link
Member

fbartho commented May 31, 2022

I admit I’m not entirely sure I understand.

Do we pre-build DangerJS binaries? (Why?) Can’t they be built on the end-user’s system, using their local processor architecture?

@417-72KI
Copy link
Member Author

Danger-Swift in Homebrew requires Danger-JS as dependency, and it seems to install pre-built binary.

I'm not familiar with npm, and don't know how to build binary from npm package even if there are other ways to install😔

@orta
Copy link
Member

orta commented May 31, 2022

Happy to have someone move the build infra into github actions and making it builds both binaries, right now it's effort enough to boot up an old mac to even make the x86 ones

@jesus-mg-ios

This comment was marked as spam.

@417-72KI
Copy link
Member Author

417-72KI commented Feb 1, 2023

Resolved by #1342 !

@417-72KI 417-72KI closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants