Wanted to know how to set CI source.

[cb-krishnapatel]

I am using github actions, and i have a image which prepared from the dockerfile which is available here. The reason for this is to not build everytime the image when the action runs. and instead of that I'm directly using the image. when I'm running the image and passing the arguments and envs, its still failing to recognise CI source. The arguments and envs i took from the way github action run happens and from its logs. Can you please help here if I'm missing something. I have added image for the command and the error.

[fbartho]

@cb-krishnapatel Looks like you missed an environment variable set by GitHub called GITHUB_WORKFLOW

danger-js/source/ci_source/providers/GitHubActions.ts

Line 237 in 81645a6

return ensureEnvKeysExist(this.env, ["GITHUB_WORKFLOW"])

As an aside, it’s not obvious to me that you’ll save time if your docker image only has DangerJS. Now if your image is pulling other dependencies that take longer to install, then that might make sense!

[fbartho]

ensureEnvKeysExists requires that the value be defined to non-empty-string.

danger-js/source/ci_source/ci_source_helpers.ts

Line 19 in 81645a6

return keys.every((key: string) => env.hasOwnProperty(key) && env[key] != null && env[key].length > 0)

If you were capturing the values from a real pull request, it would have had the name of the workflow file, I'm not sure if it's actually the filename, or if it's the configured name inside that yaml.

It looks like you're running the docker image manually, rather than having Github Actions Workflows load the docker image for you? If Github did it, then it would already have the right environment variables, and they'd just be passed in for you?

Looking at the rest of this file, there seems to only be one other GITHUB_ env var to look out for, GITHUB_EVENT_PATH (in addition to your flavor of GITHUB_TOKEN variable (there are a couple that Danger will read in different circumstances.

https://github.com/danger/danger-js/blob/81645a6a7f37534d156ad495c639c914bf7053e1/source/ci_source/providers/GitHubActions.ts

[cb-krishnapatel]

Thanks @fbartho ill have a look to this