Referencing remote dangerfile doesn't work with Typescript #1359

snowe2010 · 2023-02-09T05:31:46Z

snowe2010
Feb 9, 2023

I've tried to consolidate all our dangerfiles to a single one in our shared github actions repo, but I'm getting strange errors.

First I was getting:

Unable to evaluate the Dangerfile
 peril-downloaded-org/pricing-***/dangerfile.ts@tyler/feature/create-reusable-workflows:2
import jiraIssue from "danger-plugin-jira-issue";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at requireFromString (/usr/src/danger/node_modules/require-from-string/index.js:28:4)
    at /usr/src/danger/distribution/runner/runners/inline.js:157:68
    at step (/usr/src/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/usr/src/danger/distribution/runner/runners/inline.js:33:53)
    at /usr/src/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/src/danger/distribution/runner/runners/inline.js:23:12)
    at runDangerfileEnvironment (/usr/src/danger/distribution/runner/runners/inline.js:118:132)

Which didn't make sense to me, because I'm pretty sure those are needed, but anyway, saw this answer in another discussion so decided to remove all imports, but now I'm getting this error:

Unable to evaluate the Dangerfile
 peril-downloaded-org/pricing-***/dangerfile.ts@tyler/feature/create-reusable-workflows:30
  const text: String = fs.readFileSync(f, { encoding: "utf8" });
        ^^^^

SyntaxError: Missing initializer in const declaration
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at requireFromString (/usr/src/danger/node_modules/require-from-string/index.js:28:4)
    at /usr/src/danger/distribution/runner/runners/inline.js:157:68
    at step (/usr/src/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/usr/src/danger/distribution/runner/runners/inline.js:33:53)
    at /usr/src/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/src/danger/distribution/runner/runners/inline.js:23:12)
    at runDangerfileEnvironment (/usr/src/danger/distribution/runner/runners/inline.js:118:132)

which seems to indicate to me that it's not bothering with typescript and trying to use js, though I'm no js expert so I'm not sure if that's correct. I could be totally wrong there. Anyway, what is the expected workflow when trying to use a remote github dangerfile?

Action looks like so:

      - name: Danger
        if: ${{ always() }}
        uses: danger/danger-js@11.2.0
        env:
          SPOTLESS_FAILURE: ${{ steps.spotless.conclusion == 'failure' }}
          GITHUB_TOKEN: ${{ secrets.token }}
        with:
          args: "--dangerfile org/pricing-github-actions/dangerfile.ts@tyler/feature/create-reusable-workflows"

Answered by snowe2010

Mar 2, 2023

Issue was due to danger not parsing remote typescript files correctly. It has been fixed in #1366

View full answer

orta · 2023-02-09T09:22:51Z

orta
Feb 9, 2023
Maintainer

I bet this is because of the uses: danger/danger-js@11.2.0 - I'd recommend using Danger like a normal CLI tool which should handle this

8 replies

snowe2010 Feb 10, 2023
Author

@orta even using the cli I get the same issues:

18s
Run npm install danger danger-plugin-jira-issue

changed 1 package, and audited 141 packages in 962ms

15 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
/home/runner/.asdf/shims/npx
/home/runner/.asdf/shims/npm
Unable to evaluate the Dangerfile
 dangerfile.ts:2
import jiraIssue from "danger-plugin-jira-issue";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:74:18)
    at wrapSafe (node:internal/modules/cjs/loader:1141:20)
    at Module._compile (node:internal/modules/cjs/loader:1182:27)
    at requireFromString (/home/runner/work/document-service/document-service/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:157:68
    at step (/home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:33:53)
    at /home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:23:12)


Failing the build, there is 1 fail.
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Feedback: https://github.com/SunRun/document-service/pull/48#issuecomment-1397893399

action now looks like this:

      - name: Danger
        if: ${{ always() }}
        env:
          SPOTLESS_FAILURE: ${{ steps.spotless.conclusion == 'failure' }}
          GITHUB_TOKEN: ${{ secrets.token }}
        run: |
          npm install danger danger-plugin-jira-issue
          which npx
          which npm
          npx danger ci

orta Feb 10, 2023
Maintainer

You're not including babel or typescript, https://danger.systems/js/tutorials/transpilation.html

snowe2010 Feb 10, 2023
Author

you mean I'm not installing typescript? Even doing so it still fails.

Run npm i -g typescript
  npm i -g typescript
  npm install danger danger-plugin-jira-issue
  which npx
  which npm
  npx danger ci
  shell: /usr/bin/bash -e {0}
  env:
    ASDF_DIR: /home/runner/.asdf
    ASDF_DATA_DIR: /home/runner/.asdf
    MSYS: winsymlinks:nativestrict
    SPOTLESS_FAILURE: false
    GITHUB_TOKEN: ***

added 1 package in 1s
Reshimming asdf nodejs...

changed 1 package, and audited 141 packages in 765ms

15 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
/home/runner/.asdf/shims/npx
/home/runner/.asdf/shims/npm
Unable to evaluate the Dangerfile
 dangerfile.ts:2
import jiraIssue from "danger-plugin-jira-issue";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:74:18)
    at wrapSafe (node:internal/modules/cjs/loader:1141:20)
    at Module._compile (node:internal/modules/cjs/loader:1182:27)
    at requireFromString (/home/runner/work/document-service/document-service/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:157:68
    at step (/home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:33:53)
    at /home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/document-service/document-service/node_modules/danger/distribution/runner/runners/inline.js:23:12)


Failing the build, there is 1 fail.
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Feedback: https://github.com/SunRun/document-service/pull/48#issuecomment-1397893399

I tried both a global and local install of typescript with the same failure for both.

Why did I not need to do this before? Our dangerfile has been working fine up until this point.

snowe2010 Feb 28, 2023
Author

@orta I'm sure I'm doing something wrong, I just have no clue what.

snowe2010 Mar 2, 2023
Author

I made a PR to fix the issue #1366

snowe2010 · 2023-03-02T17:25:58Z

snowe2010
Mar 2, 2023
Author

Issue was due to danger not parsing remote typescript files correctly. It has been fixed in #1366

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Referencing remote dangerfile doesn't work with Typescript #1359

{{title}}

Replies: 2 comments 8 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Referencing remote dangerfile doesn't work with Typescript #1359

snowe2010 Feb 9, 2023

Replies: 2 comments · 8 replies

orta Feb 9, 2023 Maintainer

snowe2010 Feb 10, 2023 Author

orta Feb 10, 2023 Maintainer

snowe2010 Feb 10, 2023 Author

snowe2010 Feb 28, 2023 Author

snowe2010 Mar 2, 2023 Author

snowe2010 Mar 2, 2023 Author

snowe2010
Feb 9, 2023

Replies: 2 comments 8 replies

orta
Feb 9, 2023
Maintainer

snowe2010 Feb 10, 2023
Author

orta Feb 10, 2023
Maintainer

snowe2010 Feb 10, 2023
Author

snowe2010 Feb 28, 2023
Author

snowe2010 Mar 2, 2023
Author

snowe2010
Mar 2, 2023
Author