Testing shared danger rules

[glensc]

So, I have a project, which I deliver as docker image to be run in gitlab pipeline with bundled dangerfile in the image.

KInd of like:

danger-ci:
  stage: test
  image: $DANGER_IMAGE
  dependencies: []
  needs: []
  variables:
    DANGER_GITLAB_HOST: $CI_SERVER_HOST
    DANGER_GITLAB_API_BASE_URL: $CI_API_V4_URL
    DANGER_VERBOSE: 1
    DANGER_DANGERFILE: /app/dangerfile.js
  script:
    - export CI_MERGE_REQUEST_IID=${CI_OPEN_MERGE_REQUESTS#*!}
    - echo "Using $DANGER_DANGERFILE on merge request $CI_MERGE_REQUEST_IID"
    - danger-ci --dangerfile $DANGER_DANGERFILE --failOnErrors

that all works fine.

---

now to test the new changes in merge request, an inside same project I just override DANGER_DANGERFILE:

  DANGER_DANGERFILE: $CI_PROJECT_DIR/dangerfile.ts

that is also fine

---

But any ideas on how to run the dangerfile.ts (and its dependencies) to third-party project?

Can danger.js load files over http? or git repo? or gitlab api?

[fbartho]

If it were me, I would write the shared danger rules as a danger plugin, then each project can import the plugin and execute it within their own Dangerfiles.

You shouldn't think of the "whole" Dangerfile as itself a reusable unit, unless you're doing something like DangerJS Peril

[glensc]

so, how do I distribute the branch of danger plugin? i.e the active merge request. publish to npm registry and, so on?

each project executing shared rules is in place, I want to have a convenient way to test some branches of the shared rules.

[fbartho]

I'm not sure I understand your question(s) or scenario!

Are each of these projects in a monorepo? or are they independent repos?

A. If you're in a monorepo, then you can "just" depend on the danger-js plugin just like you depend on any other local shared library
B. If you're in separate repos, then you can publish to npm or other package repository.

I'm not sure I understand:

I want to have a convenient way to test some branches of the shared rules.

Like you want to add a new rule, and test it in some end-project, without making changes to that end project to import your beta rule?

[glensc]

I have standalone projects:

• danger-plugin
• playground

yes, I want to test the new rules in separate repo (playground) before merging the rules in shared danger.js rule project (danger-plugin).

[fbartho]

Instead of publishing to NPM, you can maybe reference the danger-plugin repo as a git-reference in your package.json? — depends on permissions to get working if danger-plugin is private, but if danger-plugin is public that would work.

For my npmJS-published packages though, I usually just publish a -beta.1 version when I’m testing stuff.